Skip to content

Update to handle Google Tag Manager using dataLayer #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
penguinstampede wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update to handle Google Tag Manager using dataLayer #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions dist/videojs.ga.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* videojs-ga - v0.4.1 - 2014-06-06
* videojs-ga - v0.4.1 - 2014-06-09
* Copyright (c) 2014 Michael Bensoussan
* Licensed MIT
*/
Expand Down Expand Up @@ -102,13 +102,23 @@
};
sendbeacon = function(action, nonInteraction, value) {
if (window.ga) {
ga('send', 'event', {
'eventCategory': eventCategory,
'eventAction': action,
'eventLabel': eventLabel,
'eventValue': value,
'nonInteraction': nonInteraction
});
if (dataLayer) {
dataLayer.push({
'event': eventCategory,
'eventAction': action,
'eventLabel': eventLabel,
'eventValue': value,
'nonInteraction': nonInteraction
});
} else {
ga('send', 'event', {
'eventCategory': eventCategory,
'eventAction': action,
'eventLabel': eventLabel,
'eventValue': value,
'nonInteraction': nonInteraction
});
}
} else if (window._gaq) {
_gaq.push(['_trackEvent', eventCategory, action, eventLabel, value, nonInteraction]);
} else {
Expand Down
4 changes: 2 additions & 2 deletions dist/videojs.ga.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 15 additions & 6 deletions src/videojs.ga.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,21 @@ videojs.plugin 'ga', (options = {}) ->
sendbeacon = ( action, nonInteraction, value ) ->
# console.log action, " ", nonInteraction, " ", value
if window.ga
ga 'send', 'event',
'eventCategory' : eventCategory
'eventAction' : action
'eventLabel' : eventLabel
'eventValue' : value
'nonInteraction' : nonInteraction
if dataLayer
dataLayer.push(
'event' : eventCategory
'eventAction' : action
'eventLabel' : eventLabel
'eventValue' : value
'nonInteraction' : nonInteraction
)
else
ga 'send', 'event',
'eventCategory' : eventCategory
'eventAction' : action
'eventLabel' : eventLabel
'eventValue' : value
'nonInteraction' : nonInteraction
else if window._gaq
_gaq.push(['_trackEvent', eventCategory, action, eventLabel, value, nonInteraction])
else
Expand Down