Skip to content

Update language dialog and remove MakeCode's own menu entry #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jul 24, 2025
Merged

Update language dialog and remove MakeCode's own menu entry #598

merged 18 commits into from
Jul 24, 2025

Conversation

microbit-grace
Copy link

@microbit-grace microbit-grace commented Jun 11, 2025 •
edited
Loading

  • Fixes Changing language inside MakeCode in CreateAI doesn't work #580 (via option 1 in issue)
  • Add flag for translationPreview for previewing CreateAI UI translations
  • Add editorVersion param for configuring MakeCode version
  • Update language dialog to have partially supported and fully supported sections
  • Add Guarani and Vietnamese languages
  • Tweak translation sync script to only update tool translations when 1 argument is passed. I think we are more likely to update the tool translations only (without the machine learning extension strings).
  • Change language dialog scroll behaviour to outside instead of inside

@microbit-grace
Update language dialog to include MakeCode
d0fd45b 
- Add flag for translationPreview for previewing CreateAI UI translations
@microbit-grace
Use beta MakeCode temporarily
859e685
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited by microbit-grace
Loading

Preview build will be at
https://review-createai.microbit.org/makecode-lang-picker/

To try with MakeCode beta from homepage:
https://review-createai.microbit.org/makecode-lang-picker/?editorVersion=beta

To try with MakeCode beta from import page:
https://review-createai.microbit.org/makecode-lang-picker/import?id=simple-ai-exercise-timer&project=Project%3A%20Simple%20AI%20exercise%20timer&name=Simple%20AI%20exercise%20timer&editors=makecode&editorVersion=beta

microbit-grace
microbit-grace commented Jun 12, 2025
View reviewed changes
microbit-grace
microbit-grace commented Jun 12, 2025
View reviewed changes
@microbit-grace microbit-grace requested review from a team and removed request for a team June 12, 2025 10:07
@microbit-grace
Copy link
Author

microbit-grace commented Jun 12, 2025 •
edited
Loading

Marked as not ready for review:

  1. Found certain issues with switching to certain langs (settings incorrect)
  2. Add editorVersion param for testing beta MakeCode more easily in the future

Update: Issues above have been resolved

@microbit-matt-hillsdon
Copy link

I'm wavering on how reasonable it is to expose these MakeCode-only languages given the small proportion of CreateAI UX they cover. Let's discuss with Adriana next week.

microbit-grace
microbit-grace commented Jul 23, 2025
View reviewed changes
@microbit-grace
Add Vietnamese and Guarani MakeCode languages
debc1eb
@microbit-grace
Update with translated strings from CrowdIn
63dbaeb
@microbit-grace
Update translation script
2116001 
to update CreateAI tool translations when only 1 arg is passed.
I think we are more likely to update CreateAI tool translations than
the machine learning strings.
@microbit-matt-hillsdon
Copy link

Is this ready for review now (still draft) ?

@microbit-grace microbit-grace marked this pull request as ready for review July 24, 2025 09:57
@microbit-grace microbit-grace changed the title [DO NOT MERGE] Update language dialog to include MakeCode Update language dialog to include MakeCode Jul 24, 2025
@microbit-grace microbit-grace merged commit 6be7b4d into main Jul 24, 2025
1 check passed
@microbit-grace microbit-grace deleted the makecode-lang-picker branch July 24, 2025 09:59
@microbit-grace microbit-grace mentioned this pull request Jul 24, 2025
Merged
@microbit-matt-hillsdon microbit-matt-hillsdon changed the title Update language dialog to include MakeCode Update language dialog and remove MakeCode's own menu entry Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microbit-robert microbit-robert microbit-robert left review comments

@microbit-matt-hillsdon microbit-matt-hillsdon microbit-matt-hillsdon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing language inside MakeCode in CreateAI doesn't work
3 participants
@microbit-grace @microbit-matt-hillsdon @microbit-robert