Handle MakeCode shareId created by logged in users #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename shortId to shareId
|
Preview build will be at |
microbit-robert
commented
Nov 13, 2025
src/App.tsx
Outdated
| throw "Not a shared key"; | ||
| if ( | ||
| !params.shareId || | ||
| !/^(_[a-zA-Z\d]{12})|(S(?:\d{5}-){3}\d{5})$/.test(params.shareId) |
Author
There was a problem hiding this comment.
This could be pulled out as a utility and have tests?
We don't have access to the backend code that produces these two type of ids to confirm that there is no additional variation we should cater for. Prefix of "_" is produced from users not logged in, prefix of "S" is from users who are logged in.
microbit-robert
commented
Nov 13, 2025
|
|
||
| test("error", async ({ openSharedProjectPage }) => { | ||
| await openSharedProjectPage.goto("_aBadSh0rt1d"); | ||
| await openSharedProjectPage.goto("_aaBadSh0rt1d"); |
Author
There was a problem hiding this comment.
Having had to update this to have the right number of characters, is it better to show a not found page when this is not valid, or better to show the potentially more helpful error case when the user has mis-copied an id?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename shortId to shareId
Closes #625