-
Notifications
You must be signed in to change notification settings - Fork 236
fix: load dashboard when only non-VS Code harness logs exist (Claude/Codex/OpenCode) #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aymenfurter
merged 2 commits into
microsoft:main
from
bryantharpe:fix/external-harness-only-discovery
May 27, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| /*--------------------------------------------------------------------------------------------- | ||
| * Copyright (c) Microsoft Corporation. All rights reserved. | ||
| * Licensed under the MIT License. See LICENSE in the project root for license information. | ||
| *--------------------------------------------------------------------------------------------*/ | ||
|
|
||
| /* Tests for external-harness source discovery used by the dashboard load gate, | ||
| * so a host with only non-VS Code logs (e.g. Claude Code on a headless | ||
| * Remote-SSH box, with no VS Code/Copilot directories) still loads. */ | ||
|
|
||
| import * as fs from 'fs'; | ||
| import * as os from 'os'; | ||
| import * as path from 'path'; | ||
| import { describe, it, expect } from 'vitest'; | ||
| import { hasExternalHarnessSources } from './parser-harnesses'; | ||
|
|
||
| function setEnv(key: 'HOME' | 'USERPROFILE', value: string | undefined): void { | ||
| if (value === undefined) delete process.env[key]; else process.env[key] = value; | ||
| } | ||
|
|
||
| /** Run `body` with HOME/USERPROFILE pointed at a fresh temp dir, restoring the | ||
| * previous values (and removing the temp dir) afterwards. Self-contained so it | ||
| * leaks no env state across tests. */ | ||
| function withHome(setup: (home: string) => void, body: () => void): void { | ||
| const prevHome = process.env.HOME; | ||
| const prevUserProfile = process.env.USERPROFILE; | ||
| const home = fs.mkdtempSync(path.join(os.tmpdir(), 'harness-home-')); | ||
| process.env.HOME = home; | ||
| process.env.USERPROFILE = home; | ||
| try { | ||
| setup(home); | ||
| body(); | ||
| } finally { | ||
| setEnv('HOME', prevHome); | ||
| setEnv('USERPROFILE', prevUserProfile); | ||
| fs.rmSync(home, { recursive: true, force: true }); | ||
| } | ||
| } | ||
|
|
||
| describe('hasExternalHarnessSources', () => { | ||
| it('returns false when no external-harness directories exist', () => { | ||
| withHome(() => { /* empty home */ }, () => { | ||
| expect(hasExternalHarnessSources()).toBe(false); | ||
| }); | ||
| }); | ||
|
|
||
| it('returns true when a Claude Code projects directory exists', () => { | ||
| withHome(home => { | ||
| fs.mkdirSync(path.join(home, '.claude', 'projects'), { recursive: true }); | ||
| }, () => { | ||
| expect(hasExternalHarnessSources()).toBe(true); | ||
| }); | ||
| }); | ||
|
|
||
| it('returns false when no home directory is set (avoids relative-path probing)', () => { | ||
| const prevHome = process.env.HOME; | ||
| const prevUserProfile = process.env.USERPROFILE; | ||
| setEnv('HOME', undefined); | ||
| setEnv('USERPROFILE', undefined); | ||
| try { | ||
| expect(hasExternalHarnessSources()).toBe(false); | ||
| } finally { | ||
| setEnv('HOME', prevHome); | ||
| setEnv('USERPROFILE', prevUserProfile); | ||
| } | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.