Skip to content

Added redux toolkit and p2party allowed deps for DefinitelyTyped #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added redux toolkit and p2party allowed deps for DefinitelyTyped #1153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/definitions-parser/allowedPackageJsonDependencies.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,7 @@
@react-native/virtualized-lists
@react-navigation/native
@react-navigation/stack
@reduxjs/toolkit
@redux-saga/types
@sentry/browser
@serverless/typescript
Expand Down Expand Up @@ -585,6 +586,7 @@
@types/next-redux-wrapper
@types/node
@types/node-fetch
@types/p2party
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you don’t need this—these @types packages are only here if another DT package needs to depend on a non-current version of the package, i.e. they need to download it from npm instead of linking in the package from the repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakebailey removed all the @types packages from this list. If you fix conflicts by removing this addition, we can merge.

@types/parse5
@types/pino
@types/prettier
Expand Down