build(build-tools): Update danger dependency (start of CVE remediation) #25081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the danger dependency from version ^12.3.3 to ^13.0.3 to address a security vulnerability (CVE-2025-25975) in a transitive dependency parse-git-config. The newer version of danger replaces the vulnerable dependency with an alternative solution.
- Updates danger dependency to v13.0.3 to eliminate vulnerable transitive dependency
- Addresses CVE-2025-25975 security vulnerability in parse-git-config
- Requires follow-up release and dev dependency update to fully resolve Component Governance alerts
Files not reviewed (1)
- build-tools/pnpm-lock.yaml: Language not supported
github-actions
bot
added
area: build
WayneFerrao
approved these changes
Jul 23, 2025
MarioJGMsoft
pushed a commit
to MarioJGMsoft/FluidFramework
that referenced
this pull request
Jul 28, 2025
…n) (microsoft#25081) ## Description Updates the `danger` dependency in build-tools to the latest version to get rid of the transitive dependency on `parse-git-config` which is affected by https://nvd.nist.gov/vuln/detail/CVE-2025-25975. A [PR](jonschlinkert/parse-git-config#15) was opened in their repo to fix it but the maintainer has not responded in several months. `danger` decided to replace it with something else in v13.0.0 (see [CHANGELOG](https://github.com/danger/danger-js/blob/main/CHANGELOG.md)). The breaking change announced there doesn't seem like something that should affect us as consumers of `danger`. Note: since build-tools has a dev dependency on a previous version of itself, fully addressing the Component Governance alert (getting rid of all references to danger<13.0.0 in lockfiles) will need us to release build-tools with this fix, and update the dev dep to that version. ## Reviewer Guidance The review process is outlined on [this wiki page](https://github.com/microsoft/FluidFramework/wiki/PR-Guidelines#guidelines). [AB#35181](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/35181)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the
dangerdependency in build-tools to the latest version to get rid of the transitive dependency onparse-git-configwhich is affected by https://nvd.nist.gov/vuln/detail/CVE-2025-25975. A PR was opened in their repo to fix it but the maintainer has not responded in several months.dangerdecided to replace it with something else in v13.0.0 (see CHANGELOG). The breaking change announced there doesn't seem like something that should affect us as consumers ofdanger.Note: since build-tools has a dev dependency on a previous version of itself, fully addressing the Component Governance alert (getting rid of all references to danger<13.0.0 in lockfiles) will need us to release build-tools with this fix, and update the dev dep to that version.
Reviewer Guidance
The review process is outlined on this wiki page.
AB#35181