Skip to content

Conversation

@scottn12
Copy link
Contributor

@scottn12 scottn12 commented Nov 26, 2025

Description

This PR updates the build pipeline on the LTS branch to use governed templates.

Reviewer Guidance

  • The 1ES injected steps occur multiple times in the pipeline run. I think this may be because they are supposed to run after each published artifact, so this may be okay.

Misc

AB#53960

@scottn12 scottn12 marked this pull request as ready for review November 26, 2025 18:55
@scottn12 scottn12 requested a review from a team as a code owner November 26, 2025 18:55
@scottn12 scottn12 requested a review from Copilot November 26, 2025 18:55
Copilot finished reviewing on behalf of scottn12 November 26, 2025 18:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the LTS branch build pipeline to use Microsoft's 1ES (One Engineering System) governed templates for enhanced security and compliance. The migration replaces traditional Azure DevOps pipeline structure with the 1ES.Official.PipelineTemplate, which provides built-in SDL (Security Development Lifecycle) features including Arrow service integration for artifact shipping.

Key changes:

  • Migrated from standalone pipeline to 1ES Pipeline Templates framework
  • Integrated Arrow service connection for secure artifact publishing with shouldShip parameter
  • Converted artifact publishing from task-based (PublishBuildArtifacts@1) to declarative templateContext.outputs

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tools/pipelines/templates/build-npm-package.yml Complete migration to 1ES templates with SDL/Arrow configuration, artifact publishing moved to templateContext outputs, component governance job removed (now handled by 1ES), and template paths updated to use @self references
tools/pipelines/build-client.yml Added shouldShip parameter configuration to control Arrow artifact shipping for release and prerelease builds

Copy link
Contributor

@alexvy86 alexvy86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell; the PR build will tell us if we missed anything.

@scottn12 scottn12 requested a review from alexvy86 November 26, 2025 20:02
@scottn12 scottn12 enabled auto-merge (squash) November 26, 2025 20:45
@scottn12 scottn12 disabled auto-merge November 26, 2025 21:49
@scottn12 scottn12 merged commit 131180e into lts Nov 26, 2025
28 checks passed
@scottn12 scottn12 deleted the test/lts-gov-template branch November 26, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants