-
Notifications
You must be signed in to change notification settings - Fork 559
security: Use governed template for LTS build pipeline #25931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates the LTS branch build pipeline to use Microsoft's 1ES (One Engineering System) governed templates for enhanced security and compliance. The migration replaces traditional Azure DevOps pipeline structure with the 1ES.Official.PipelineTemplate, which provides built-in SDL (Security Development Lifecycle) features including Arrow service integration for artifact shipping.
Key changes:
- Migrated from standalone pipeline to 1ES Pipeline Templates framework
- Integrated Arrow service connection for secure artifact publishing with
shouldShipparameter - Converted artifact publishing from task-based (
PublishBuildArtifacts@1) to declarativetemplateContext.outputs
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/pipelines/templates/build-npm-package.yml | Complete migration to 1ES templates with SDL/Arrow configuration, artifact publishing moved to templateContext outputs, component governance job removed (now handled by 1ES), and template paths updated to use @self references |
| tools/pipelines/build-client.yml | Added shouldShip parameter configuration to control Arrow artifact shipping for release and prerelease builds |
Co-authored-by: Copilot <[email protected]>
alexvy86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as far as I can tell; the PR build will tell us if we missed anything.
Description
This PR updates the build pipeline on the LTS branch to use governed templates.
Reviewer Guidance
Misc
AB#53960