Allow bytes-like inputs in MarkItDown.convert#1588
Open
lavish0000 wants to merge 1 commit intomicrosoft:mainfrom
Open
Allow bytes-like inputs in MarkItDown.convert#1588lavish0000 wants to merge 1 commit intomicrosoft:mainfrom
lavish0000 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
1 similar comment
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #287
Summary:
bytes,bytearray, andmemoryviewinputs inMarkItDown.convert()io.BytesIOso they follow the existing stream conversion pathTesting:
uv run --project packages/markitdown --with pytest,mypy python -m pytest packages/markitdown/tests/test_module_misc.py -k 'bytes_like or input_as_strings'uv run --project packages/markitdown --with ruff python -m ruff check packages/markitdown/src/markitdown/_markitdown.py packages/markitdown/tests/test_module_misc.pyuv run --project packages/markitdown --with ruff python -m ruff format --check packages/markitdown/src/markitdown/_markitdown.py packages/markitdown/tests/test_module_misc.pyNote: