UefiHidDxeV2: Fix Keyboard LED Sync Issue #641
Merged
apop5 merged 4 commits intomicrosoft:dev/202405from Mar 5, 2025
wenbhou:personal/wenbhou/fix_rust_kb_led
Merged
UefiHidDxeV2: Fix Keyboard LED Sync Issue #641apop5 merged 4 commits intomicrosoft:dev/202405from wenbhou:personal/wenbhou/fix_rust_kb_led
apop5 merged 4 commits intomicrosoft:dev/202405from
wenbhou:personal/wenbhou/fix_rust_kb_led
Conversation
# Conflicts: # HidPkg/UefiHidDxeV2/src/keyboard.rs
github-actions
bot
added
the
type:backport
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #641 +/- ##
===========================================
Coverage 11.59% 11.59%
===========================================
Files 132 132
Lines 21558 21558
Branches 2546 2546
===========================================
Hits 2499 2499
Misses 19025 19025
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joschock
approved these changes
Mar 5, 2025
makubacki
approved these changes
Mar 5, 2025
apop5
approved these changes
Mar 5, 2025
ProjectMuBot
pushed a commit
that referenced
this pull request
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #642
Current UefiHidDxeV2 is unable to sync the keyboard LED state from the integrated keyboard to external USB keyboards connected to a laptop, resulting in a poor user experience.
This change aims to fix this issue to ensure the keyboard LED state can sync between the integrated keyboard and external USB keyboards.
How This Was Tested
Tested on the Laptop, the keyboard LED state can sync between the integrated keyboard and external USB keyboards.
Integration Instructions
N/A