[REBASE & FF] Copy FltUsedLib to MsCorePkg#864
Merged
os-d merged 3 commits intomicrosoft:release/202511from Apr 1, 2026
Merged
[REBASE & FF] Copy FltUsedLib to MsCorePkg#864os-d merged 3 commits intomicrosoft:release/202511from
os-d merged 3 commits intomicrosoft:release/202511from
Conversation
mu-automation
bot
added
the
impact:non-functional
This was referenced Apr 1, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202511 #864 +/- ##
================================================
Coverage ? 8.29%
================================================
Files ? 73
Lines ? 8779
Branches ? 579
================================================
Hits ? 728
Misses ? 8038
Partials ? 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vineelko
approved these changes
Apr 1, 2026
makubacki
reviewed
Apr 1, 2026
makubacki
approved these changes
Apr 1, 2026
This migrates FltUsedLib from MdePkg to MsCorePkg, as it is only used in mu_plus. It defines a global variable that MSVC and clang expect when floating point is used. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
MfciPkg.dsc doesn't build any components that use FltUsedLib. Drop the references. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
Consume the new FltUsedLib in MsCorePkg instead of MdePkg. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
vineelko
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FltUsedLib is a library that has a single line, adding a reference to
_fltused, which is needed by MSVC and clang when building floating point code.FltUsedLib is only used in mu_plus, so in order to reduce deltas from edk2, it is moved to mu_plus. This commit then updates references in mu_plus to this new library.
A PR will be put up to mu_basecore to drop the library after this merges.
How This Was Tested
Build testing.
Integration Instructions
Platforms should update to
FltUsedLib|MsCorePkg/Library/FltUsedLib/FltUsedLib.infin their DSCs. This change is not a breaking change, but the removal in mu_basecore will be.