Skip to content

Fix a bug in action_failed event class get_description() function return data type #2843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Parent: add missing import of external_format_value
wants to merge 1 commit into
base: MOODLE_401_STABLE
Choose a base branch
from
Open

Fix a bug in action_failed event class get_description() function return data type #2843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion auth/oidc/classes/event/action_failed.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public static function get_name() {
* @return string
*/
public function get_description() {
return $this->data['other'];
return json_encode($this->data['other']);
Copy link

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While wrapping $this->data['other'] with json_encode fixes the data type issue, consider adding error handling for json_encode failure cases to prevent unexpected behavior if encoding fails.

Suggested change
return json_encode($this->data['other']);
$json = json_encode($this->data['other']);
if ($json === false) {
// Log the error and return a fallback value.
debugging('Failed to encode $this->data["other"] to JSON: ' . json_last_error_msg(), DEBUG_DEVELOPER);
return '{"error": "Failed to encode data"}';
}
return $json;

Copilot uses AI. Check for mistakes.
}

/**
Expand Down