Fix a bug in action_failed event class get_description() function return data type

[weilai-irl]

No description provided.

[Copilot]

Pull Request Overview

This PR ensures that get_description() in the action_failed event always returns a string by JSON-encoding its structured payload.

• Changed the return value of get_description() from raw data to a JSON-encoded string.
• Updated the implementation in auth/oidc/classes/event/action_failed.php.

Comments suppressed due to low confidence (2)

auth/oidc/classes/event/action_failed.php:44

• Update the docblock to note that the returned string is a JSON-encoded representation of the other data, so future readers know the format.

     * @return string

auth/oidc/classes/event/action_failed.php:47

• Add or update unit tests to verify that get_description() correctly JSON-encodes various other payload structures and handles encoding errors as expected.

        return json_encode($this->data['other']);

[Copilot]

Consider adding JSON_THROW_ON_ERROR (e.g., json_encode(..., JSON_THROW_ON_ERROR)) to catch encoding failures explicitly instead of returning false on error.

Suggested change

	return json_encode($this->data['other']);
	try {
	return json_encode($this->data['other'], JSON_THROW_ON_ERROR);
	} catch (\JsonException $e) {
	// Log the error or handle it appropriately.
	error_log('JSON encoding error: ' . $e->getMessage());
	return '{}'; // Return an empty JSON object as a fallback.
	}