Repo: Explicitly specify static crt for musl targets #1893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR explicitly configures the Rust compiler to use static CRT (C Runtime) linking for musl targets by adding the -Ctarget-feature=+crt-static flag. This change proactively addresses a future Rust compiler default behavior change while maintaining current functionality and avoiding warning noise.
Key changes:
- Adds explicit static CRT configuration for musl targets in Cargo configuration
chris-oo
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently Rust's default behavior, but it will be changing at some point in the future (rust-lang/rust#144513). Just specifying it explicitly now doesn't hurt, and avoids the warning noise whenever it shows up.