nvme_test: Added NvmeWorkersContext input for the NvmeWorkers struct #1913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a NvmeWorkersContext struct to encapsulate all the input parameters needed to create NvmeWorkers, simplifying the constructor interface and preparing for Function Level Reset (FLR) support where new NvmeWorkers instances need to be created.
- Introduces
NvmeWorkersContextstruct to group all constructor parameters - Refactors
NvmeWorkers::new()to accept the context struct instead of individual parameters - Updates the
FaultConfigurationstructs to be cloneable
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| coordinator.rs | Defines NvmeWorkersContext struct and refactors NvmeWorkers::new() to use it |
| workers.rs | Exports the new NvmeWorkersContext struct |
| pci.rs | Updates call site to use NvmeWorkersContext with named field initialization |
| fault.rs | Adds Clone derive to fault configuration structs |
smalis-msft
reviewed
Aug 25, 2025
smalis-msft
reviewed
Aug 25, 2025
smalis-msft
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a support PR being made to reduce size of #1858. Added
NvmeWorkersContextthat stores the input forNvmeWorkers. This will subsequently be used to create newNvmeWorkerswhen FLR is issued to the test controller.