petri: hyper-v reset support #1916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for guest resets in the Hyper-V petri backend, enabling Hyper-V to handle VM reset operations automatically. The implementation refactors framebuffer code to be compatible with the reset feature and enables reboot tests that were previously only possible with OpenVMM.
- Refactors VM halt handling to distinguish between different halt reasons (PowerOff, Reset, TripleFault, etc.)
- Adds automatic reset handling for VMs that require initial reboots
- Enables Hyper-V reboot tests across multiple test configurations
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| vmm_tests/vmm_tests/tests/tests/*.rs | Updates test assertions to use new PetriHaltReason enum instead of HaltReason |
| vmm_tests/petri_artifacts_vmm_test/src/lib.rs | Adds guest quirks for VMs requiring initial reboots |
| petri/src/vm/mod.rs | Introduces PetriHaltReason enum and refactors halt handling with reset support |
| petri/src/vm/openvmm/*.rs | Updates OpenVMM backend to support new halt reason handling |
| petri/src/vm/hyperv/*.rs | Implements Hyper-V reset support with halt event monitoring and framebuffer refactoring |
| petri/petri_artifacts_common/src/lib.rs | Adds initial_reboot_required quirk to guest configuration |
tjones60
force-pushed
the
hyperv_petri_restart_3
branch
from
470b2e7 to
c1f38cc
Compare
tjones60
force-pushed
the
hyperv_petri_restart_3
branch
from
c1f38cc to
ac95724
Compare
smalis-msft
reviewed
Aug 26, 2025
smalis-msft
reviewed
Aug 26, 2025
smalis-msft
reviewed
Aug 26, 2025
smalis-msft
reviewed
Aug 26, 2025
smalis-msft
reviewed
Aug 26, 2025
smalis-msft
reviewed
Aug 26, 2025
smalis-msft
reviewed
Aug 26, 2025
smalis-msft
reviewed
Aug 26, 2025
smalis-msft
reviewed
Aug 27, 2025
smalis-msft
reviewed
Aug 27, 2025
smalis-msft
approved these changes
Aug 28, 2025
tjones60
added a commit
to tjones60/openvmm
that referenced
this pull request
Sep 2, 2025
Add support for guest resets for the Hyper-V petri backend. Refactors some of the framebuffer code to make this possible. Enables Hyper-V reboot tests that are now possible due to this change. Also includes some other minor Petri refactoring to move more logic into backend-agnostic code.
tjones60
added
the
backport_2505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for guest resets for the Hyper-V petri backend. Refactors some of the framebuffer code to make this possible. Enables Hyper-V reboot tests that are now possible due to this change. Also includes some other minor Petri refactoring to move more logic into backend-agnostic code.