Skip to content

netvsp: adding LSO validation logic to handle_rndis_packet_message #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

netvsp: adding LSO validation logic to handle_rndis_packet_message #2148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65dbf43
Adding validation logic to handle_rndis_packet_message
erfrimod Oct 10, 2025
7fe50de
PR feedback
erfrimod Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions vm/devices/net/netvsp/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1901,6 +1901,10 @@ enum WorkerError {
RndisMessageTooSmall,
#[error("unsupported rndis behavior")]
UnsupportedRndisBehavior,
#[error("invalid lso packet with insufficient segments: {0}")]
InvalidLsoPacketInsufficientSegments(u32),
#[error("invalid lso packet with first segment size: {0}")]
InvalidLsoPacketFirstSegmentSize(u32),
#[error("vmbus queue error")]
Queue(#[from] queue::Error),
#[error("too many control messages")]
Expand Down Expand Up @@ -2477,6 +2481,20 @@ impl<T: RingMem> NetChannel<T> {
});
}

if metadata.offload_tcp_segmentation {
if segments.len() < 2 {
return Err(WorkerError::InvalidLsoPacketInsufficientSegments(
segments.len() as u32,
));
}
let first_segment_size = segments[0].len;
if first_segment_size > 256 {
return Err(WorkerError::InvalidLsoPacketFirstSegmentSize(
first_segment_size,
));
}
}

metadata.segment_count = segments.len() - start;

stats.tx_packets.increment();
Expand Down
Loading