Skip to content

disk_striped: Fix the divide-by-zero error when chunk_size_in_kb field is missing in VTL2 settings #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

disk_striped: Fix the divide-by-zero error when chunk_size_in_kb field is missing in VTL2 settings #2153

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b943fe
Fix the default value for chunk_size
SrinivasShekar Oct 13, 2025
7c9e351
fmt fixes
SrinivasShekar Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion vm/devices/storage/disk_striped/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,9 @@ impl StripedDisk {
let sector_size = devices[0].sector_size();
let sector_count = devices[0].sector_count();
let read_only = devices[0].is_read_only();
let chunk_size_in_bytes = chunk_size_in_bytes.unwrap_or(CHUNK_SIZE_128K);
let chunk_size_in_bytes = chunk_size_in_bytes
.filter(|&chunk_size| chunk_size != 0)
.unwrap_or(CHUNK_SIZE_128K);
if !chunk_size_in_bytes.is_multiple_of(sector_size) {
return Err(NewDeviceError::InvalidChunkSize(
chunk_size_in_bytes,
Expand Down