firmware_uefi: EfiDiagnostics refactor

[maheeraeron]

This PR simply refactors EfiDiagnostics into a module with multiple files that separate different responsibilities, since this started to bloat after some time

[Copilot]

Pull Request Overview

This PR refactors the EfiDiagnostics module from a single large file into a well-organized module structure with separate files for different responsibilities. The refactor improves code maintainability by separating parsing, processing, message accumulation, and formatting logic into distinct modules.

Key changes:

• Split monolithic diagnostics.rs into a module with four specialized files
• Created dedicated modules for processor, parser, message accumulator, and formatting logic
• Maintained all existing functionality while improving code organization

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
vm/devices/firmware/firmware_uefi/src/service/diagnostics/processor.rs	Contains core processing logic for EFI diagnostics buffer with error handling
vm/devices/firmware/firmware_uefi/src/service/diagnostics/parser.rs	Handles entry parsing utilities for EFI diagnostics buffer
vm/devices/firmware/firmware_uefi/src/service/diagnostics/mod.rs	Main module file with public API and re-exports from submodules
vm/devices/firmware/firmware_uefi/src/service/diagnostics/message_accumulator.rs	Manages message accumulation state and processing logic
vm/devices/firmware/firmware_uefi/src/service/diagnostics/formatting.rs	Contains log formatting and output utilities
vm/devices/firmware/firmware_uefi/src/service/diagnostics.rs	Original file completely removed as part of the refactor

Comments suppressed due to low confidence (1)

vm/devices/firmware/firmware_uefi/src/service/diagnostics/processor.rs:1

• The bytes_read field is being updated inside the entry processing loop, but it should be updated after successfully processing each entry. Currently, it's updated even if the entry processing fails later in the accumulator.

// Copyright (c) Microsoft Corporation.

[maheeraeron]

I moved around a lot of things, but the core logic should still be the same and functionally there is no difference. If there are areas where I should optimize something or move things around, please LMK

[smalis-msft]

This shouldn't be needed, it should be the default workspace wide.

[smalis-msft]

One nit