fix(browser_console_messages): fix zod .default().describe() schema order#40360
Open
Will-hxw wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(browser_console_messages): fix zod .default().describe() schema order#40360Will-hxw wants to merge 1 commit intomicrosoft:mainfrom
Will-hxw wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…sages level param Fixes: microsoft/playwright-mcp#1429 When using zod with zodToJSONSchema, .describe() must come before .default() to ensure the description is properly attached to the schema before the JSON schema is generated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.default('info').describe(...)to.describe(...).default('info')for the level parameter in console.tsWhy
Issue #1429: Gemini calls browser_console_messages and receives "parameters.level schema didn't specify the schema type field". When
.default()appears before.describe()in zod chaining, zodToJSONSchema drops the description, causing schema validation failure.Validation