Skip to content

Conversation

@vineethkuttan
Copy link
Contributor

@vineethkuttan vineethkuttan commented Dec 24, 2025

Description

Brings latest hermes-windows code that implements JSI version 21.

node api-jsi PR ref :
microsoft/node-api-jsi#17
commit hash : 4b8a4a59c4e1b7b988b809dedffd89a7662aa785

Hermes-windows ref:
microsoft/hermes-windows#260

Type of Change

  • New feature (non-breaking change which adds functionality)

Why

Brings latest hermes-windows code that implements JSI version 21 , which is used by 0.82 meta RN nightly.

What

Brings latest hermes-windows code that implements JSI version 21.

Screenshots

image

Testing

Tested build , playground in debug and release

Changelog

Should this change be included in the release notes: indicate: no

Microsoft Reviewers: Open in CodeFlow

@iamAbhi-916 iamAbhi-916 marked this pull request as ready for review December 24, 2025 09:28
@iamAbhi-916 iamAbhi-916 requested a review from a team as a code owner December 24, 2025 09:28
Copy link
Contributor

@iamAbhi-916 iamAbhi-916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@iamAbhi-916 iamAbhi-916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add v8-jsi PR ref to this PR description (Once completed), just to keep track of all places we upgrade for JSI.

@vineethkuttan
Copy link
Contributor Author

vineethkuttan commented Dec 24, 2025

Also add v8-jsi PR ref to this PR description (Once completed), just to keep track of all places we upgrade for JSI.

v8-jsi is not updated till now. I have to do some more changes for that. Will do it soon.

@iamAbhi-916 iamAbhi-916 merged commit 857247f into microsoft:main Dec 24, 2025
30 checks passed
@vineethkuttan vineethkuttan deleted the bump_jsi branch December 24, 2025 10:49
@vineethkuttan vineethkuttan self-assigned this Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants