feat(indexer-api): add gRPC service for transactions#5
Draft
hseeberger wants to merge 2 commits intomainfrom
Draft
feat(indexer-api): add gRPC service for transactions#5hseeberger wants to merge 2 commits intomainfrom
hseeberger wants to merge 2 commits intomainfrom
Conversation
|
New Issues (49)Checkmarx found the following issues in this Pull Request
Fixed Issues (40)Great job! The following issues were fixed in this Pull Request
|
hseeberger
force-pushed
the
feat/api-grpc
branch
4 times, most recently
from
85ec152 to
1c27cfb
Compare
Contributor
|
There's a question here as to if gRPC with protobuf or scale with its metadata support. Either would be a tight binary codec. Though if we need to we could support both. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users must send their viewing key to our hosted Indexer. This PR enables to create a locally running (separate from our hosted one, also exposing an API) Wallet Indexer (the part that needs the viewing key) that gets the transactions from our hosted Indexer.
All transactions, hence need for speed. gRPC should perform much better here for our transactions which are a lot of binary data (GraphQL over Websocket needs hex-encoding). So this locally running Indexer would know all transactions and be the only component that gets the users' viewing key for these users who do not want to trust us.