Add method to get details from Dial Code#14
Open
SamadiPour wants to merge 3 commits intomiguelpruivo:masterfrom
Open
Add method to get details from Dial Code#14SamadiPour wants to merge 3 commits intomiguelpruivo:masterfrom
SamadiPour wants to merge 3 commits intomiguelpruivo:masterfrom
Conversation
| (element) => element['dial_code'] == dialCode, | ||
| orElse: () => null, | ||
| ); | ||
| if (data != null) return CountryDetails.fromMap(data); |
Owner
There was a problem hiding this comment.
Can you please make it explicitly to return null if no condition is met? Also, please use the {} in if statements. Thank you!
miguelpruivo
force-pushed
the
master
branch
2 times, most recently
from
354b478 to
e84f3ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.