chore: expand tooling, docs, and test coverage#8
Merged
Conversation
- CI: migrate CodeQL to Advanced matrix (adds actions scanning), scope permissions, add caching/concurrency/timeout to pr-check, pin mise-action to a SHA - Lint: expand golangci-lint linter set, set golines max-len 120, bump golangci-lint to 2.12.2; verify config in `make lint` - Devcontainer: add github-cli feature, mise/toml VSCode extensions, lockfile, harden post_create.sh - Docs: rename AGENTS.md -> CLAUDE.md, add Features/type table to README, add Traditional Chinese README - Tests: cover non-comparable Map values, ComparableMap Swap and LoadAndDelete, add ExampleComparableMap Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tooling, documentation, and test-coverage improvements. No production code (
map.go/comparable_map.go) changes.CI
actionslanguage scanning and scope job permissions.pr-check: addcontents: readpermission, concurrency cancel-in-progress, a 15-min timeout, Go module/build + golangci-lint caching, and pinmise-actionto a commit SHA.Lint / tooling
gocritic,modernize,gomodguard_v2,copyloopvar,usetesting, …), setgolines max-len: 120, dropswaggo/goheader.2.11.2→2.12.2;make lintnow runsgolangci-lint config verifyfirst.Devcontainer
github-clifeature, recommend mise/even-better-toml VSCode extensions, adddevcontainer-lock.json, hardenpost_create.sh(set -euo pipefail, optional local hook).Docs
AGENTS.md→CLAUDE.mdwith expanded guidance.README.md; add Traditional ChineseREADME.zh-TW.md.Tests
Mapvalues,ComparableMap.Swap,ComparableMap.LoadAndDelete, and addExampleComparableMap.Test plan
make check(tidy + lint + race tests) passes.make lint NEW_FROM_REV=(full-tree lint) reports 0 issues.🤖 Generated with Claude Code