feat: add MustLoadTimeZone and fix CI for fork PRs#4
Merged
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
Add MustLoadTimeZone as a panic-on-error variant of LoadTimeZone for use in variable initializations and tests. Suppress recvcheck lint for the intentional mixed-receiver pattern on TimeZone. Run coverage upload on pull_request events and make fail_ci_if_error conditional so tokenless fork uploads don't break CI. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
min0625
force-pushed
the
feat/must-load-time-zone
branch
from
c04673e to
a4efae3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MustLoadTimeZone— a panic-on-error variant ofLoadTimeZonefor use in variable initializations and testsrecvcheckexclusion in.golangci.yamlfor the intentional mixed-receiver pattern onTimeZone(pointer receivers for mutating methods, value receivers for the rest)pull_requestevents and makefail_ci_if_errorconditional so tokenless fork PR uploads don't break CITest plan
make checkpasses (tidy + lint + test with-race)TestMustLoadTimeZonecovers: zero value ("","UTC"), valid zone, panic on"Local", panic on invalid nameExampleMustLoadTimeZoneruns as a doc example🤖 Generated with Claude Code