test: add unsupported-type Scan case and clarify examples#5
Merged
Conversation
Add a table-driven test entry that verifies Scan rejects an unsupported input type ([]int) while leaving the receiver unchanged. Also split a chained one-liner in ExampleTimeZone and add inline comments to the zero-value and SQL Value examples to surface the UTC-as-zero-value and no-NULL invariants directly in the runnable docs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestTimeZone_Scanthat verifiesScanrejects an unsupported input type ([]int) while leaving the receiver unchangedExampleTimeZoneinto a named variable for readabilityExampleTimeZone_zeroValueandExampleTimeZone_Value_zeroValueto surface the UTC-as-zero-value and no-NULL invariants directly in the runnable docsTest plan
make testpasses (new test case covered by table-driven runner)make lintpasses (no new linting issues)🤖 Generated with Claude Code