feat: add Equal method and AppendText support#6
Merged
Conversation
Add TimeZone.Equal for comparing two values by IANA name, since a TimeZone holds a *time.Location and time.LoadLocation returns a distinct pointer per call, making == unreliable for non-zero values. Implement encoding.TextAppender via AppendText and have MarshalText delegate to it, removing duplication. Add table-driven tests and runnable examples for both. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TimeZone.Equalto compare two values by IANA name. ATimeZoneholds a*time.Locationandtime.LoadLocationreturns a distinct pointer on each call, so==is unreliable for non-zero values.Equalcompares viaString(), which preserves the UTC-as-zero-value invariant.encoding.TextAppenderviaAppendText;MarshalTextnow delegates to it, removing duplication. (TextAppenderis Go 1.24+, which the project already targets.)encoding.TextAppendercompile-time interface assertion.Tests
EqualandAppendText.Exampletests for both.make testandmake lintpass.🤖 Generated with Claude Code