Add table maintenance API req/rsp structs based on S3 Tables APIs#533
Open
dhananjaykrutika wants to merge 2 commits intominio:mainfrom
Open
Add table maintenance API req/rsp structs based on S3 Tables APIs#533dhananjaykrutika wants to merge 2 commits intominio:mainfrom
dhananjaykrutika wants to merge 2 commits intominio:mainfrom
Conversation
dhananjaykrutika
requested review from
hackintoshrao,
harshavardhana,
kannappanr and
twuebi
klauspost
reviewed
Feb 6, 2026
Comment on lines
+51
to
+53
| // IcebergCompaction is a placeholder for future compaction settings. | ||
| // Currently not implemented but reserved for API compatibility. | ||
| IcebergCompaction *json.RawMessage `json:"icebergCompaction,omitempty"` |
Contributor
There was a problem hiding this comment.
Why is it we don't add the existing type?
Without more details, it seems strictly worse to add it like this than omitting it, since you would inevitably break API compatibility when you add it.
(also you shouldn't need a pointer to json.RawMessage since it has a slice that can be nil).
Comment on lines
+32
to
+33
| MaintenanceStatusEnabled = "enabled" | ||
| MaintenanceStatusDisabled = "disabled" |
Contributor
There was a problem hiding this comment.
I suggest you add a type MaintenanceStatus string and make these typed.
Comment on lines
+26
to
+27
| MaintenanceTypeIcebergSnapshotManagement = "icebergSnapshotManagement" | ||
| MaintenanceTypeIcebergCompaction = "icebergCompaction" |
Contributor
There was a problem hiding this comment.
I don't see where/how these are used?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.aws.amazon.com/AmazonS3/latest/API/API_s3Buckets_PutTableMaintenanceConfiguration.html
https://docs.aws.amazon.com/AmazonS3/latest/API/API_s3Buckets_GetTableMaintenanceConfiguration.html