Skip to content

Fix require_permission dependency#37

Open
przlada wants to merge 1 commit intomirumee:mainfrom
przlada:fix-require-permission-dependency
Open

Fix require_permission dependency#37
przlada wants to merge 1 commit intomirumee:mainfrom
przlada:fix-require-permission-dependency

Conversation

@przlada
Copy link
Copy Markdown

@przlada przlada commented Jul 28, 2022

I want to merge this change because it fixes require_permission dependency.

@przlada przlada force-pushed the fix-require-permission-dependency branch from b1baac5 to 5db723c Compare July 29, 2022 09:01
@pkucmus
Copy link
Copy Markdown
Contributor

pkucmus commented Jul 29, 2022

Thanks, please tell me, what was broken here, I can't seem to make sense of it.

@przlada
Copy link
Copy Markdown
Author

przlada commented Jul 29, 2022

@pkucmus this line wasn't working for me:

jwt_payload = jwt.decode(saleor_token, verify=False)

it should be

jwt_payload = jwt.JWT().decode(token, do_verify=False)

from what I found

@pkucmus
Copy link
Copy Markdown
Contributor

pkucmus commented Jul 30, 2022

That's not good. I wonder if we have fallen into the https://pyjwt.readthedocs.io/en/latest/ vs https://pypi.org/project/jwt/ trap here, I need to look deeper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants