Fix custom categories not showing up when using the categories prop#961
Open
mahmed2000 wants to merge 1 commit into
Open
Fix custom categories not showing up when using the categories prop#961mahmed2000 wants to merge 1 commit into
mahmed2000 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #951 and #959.
052badf added a new array to store the categories on first mount to filter on. Since the custom categories never pushed to it, they would never show up if the categories prop was used.
This just creates another array to store the custom categories, and makes the category prop filter on the combined original and custom categories.