feat: Add --issueStatuses flag to sonarqube2hdf command#6661
feat: Add --issueStatuses flag to sonarqube2hdf command#6661mikeBoterf wants to merge 4 commits intomitre:mainfrom
Conversation
|
This pull request has a conflict. Could you fix it @mikeBoterf? |
|
Recent changes have been pushed to the linked heimdall2 PR (mitre/heimdall2#7791) based on review feedback from @Amndeep7. The |
Amndeep7
left a comment
There was a problem hiding this comment.
There's a merge conflict that needs to be resolved
There was a problem hiding this comment.
Merge conflict needs to be resolved and i would run the linter too just to make sure it picks up everything
There was a problem hiding this comment.
Done — rebased on main, linter came back clean.
There was a problem hiding this comment.
Don't forget to update the readme to reflect the new functionality - it's mostly just copy pasting the help block into the readme and then formatting it nicely
There was a problem hiding this comment.
Added — flag description and USAGE line updated in the README.
…ist approach Update flag semantics to match heimdall2 review feedback: - Rename flag from --issueStatuses to --excludeIssueStatuses - Flag now specifies additional statuses to EXCLUDE (deny-list) rather than a full replacement list (allow-list) - Update description to explain default exclusions and usage - Update usage string to include the new flag
834b344 to
e62af78
Compare
|
@Amndeep7 Rebased on main (merge conflict resolved), ran the linter (clean), and added the new |
Amndeep7
left a comment
There was a problem hiding this comment.
This PR should be good after this fix and once the upstream heimdall monorepo PR is merged.
There was a problem hiding this comment.
please add another example (and update the readme accordingly) using this new flag
There was a problem hiding this comment.
Added in 3b6a88f8 — second example showing -s flag with custom exclusions, in both the command and README.
Add second example showing -s flag with custom exclusions to both the command definition and README.
|



Summary
Adds a new
--issueStatuses(-s) flag to thesaf convert sonarqube2hdfcommand. This flag allows users to specify a comma-separated list of issue
statuses to include when pulling issues from the SonarQube API.
Changes
issueStatusesflag (short:-s) to thesonarqube2hdfcommandSonarqubeResultsconstructor in@mitre/hdf-convertersUsage
Motivation
The upstream
@mitre/hdf-converterslibrary now supports dynamic issue statusdiscovery and a user-supplied override (see mitre/heimdall2#7791). This change
exposes that capability through the SAF CLI so operators can control which issue
statuses are retrieved without modifying source code.
Related
discovery and the
issueStatusesconstructor parameter