Skip to content

Conversation

zanieb
Copy link

@zanieb zanieb commented Jul 25, 2025

@musicinmybrain
Copy link
Contributor

I would have proposed this when I patched the dependency in the Fedora package, rust-insta and opened astral-sh/uv#14890, but I saw that the insta crate still supports Rust 1.64.0, and that console bumped their MSRV to 1.66 sometime after console 0.15.4, which is the version in Cargo.lock. I don’t know how that MSRV was chosen or whether it is time to consider raising it.

@zanieb
Copy link
Author

zanieb commented Jul 26, 2025

👍 I'll admit I did not check the MSRV

@max-sixty
Copy link
Collaborator

how viable would it be to have an MSRV for cargo-insta of 1.66, without bumping MSRV of insta?

we just bumped the overall MSRV to 1.64, so am hesitant to bump it up further; @mitsuhiko has always been keen on compat

alternatively, can we support 0.15 & 0.16? then we're less likely to be holding any other libraries back...

@zanieb
Copy link
Author

zanieb commented Aug 5, 2025

For what it's worth, I'm not in a huge rush here. It's just wasteful to compile the crate multiple times. I also think insta feels fairly stable and blocking upgrade on MSRV doesn't seem like a big deal, but 🤷‍♀️

@dpaoliello
Copy link

alternatively, can we support 0.15 & 0.16? then we're less likely to be holding any other libraries back...

I don't think that's possible: the std feature was added in 0.16 so a simple version range won't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants