[WIP] Prek in replacement of pre-commit#16089
Draft
acolombier wants to merge 1 commit intomixxxdj:2.6from
Draft
Conversation
a56da01 to
ebc6753
Compare
Member
Author
|
First run was lightning fast! 27s with cold cache Looking at debug logs, hook install are all done within seconds but on the second run, It could be related to a slowly performing pip install (bandwidth?). Will retry a few time |
ebc6753 to
453659e
Compare
Member
Author
|
Turned out this was expected and is the result of @mixxxdj/developers should we test that in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a test to assert the situation with prek, which claim better results than pre-commit and is now widely adopted
For reference, the avg runtime for pre-commit is 4m41.