Skip to content

[WIP] Prek in replacement of pre-commit#16089

Draft
acolombier wants to merge 1 commit intomixxxdj:2.6from
acolombier:chore/use-prek
Draft

[WIP] Prek in replacement of pre-commit#16089
acolombier wants to merge 1 commit intomixxxdj:2.6from
acolombier:chore/use-prek

Conversation

@acolombier
Copy link
Member

@acolombier acolombier commented Mar 3, 2026

This is a test to assert the situation with prek, which claim better results than pre-commit and is now widely adopted

For reference, the avg runtime for pre-commit is 4m41.

@acolombier acolombier marked this pull request as draft March 3, 2026 09:37
@acolombier acolombier changed the base branch from main to 2.5 March 3, 2026 10:06
@acolombier
Copy link
Member Author

acolombier commented Mar 3, 2026

First run was lightning fast! 27s with cold cache
Second run was unbelievably slow, tho also operating on cold cache apparently: 6m42s

Looking at debug logs, hook install are all done within seconds but on the second run, qsscheck has taken 6m22 to install, without much details as of why it was this slow.

It could be related to a slowly performing pip install (bandwidth?). Will retry a few time

@acolombier
Copy link
Member Author

Turned out this was expected and is the result of qml_formater, which has been removed in 2.7/main

@mixxxdj/developers should we test that in main and see if we see better results? (CI runtime)

@acolombier acolombier added this to the 2.6.0 milestone Mar 13, 2026
@acolombier acolombier changed the base branch from 2.5 to 2.6 March 13, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant