Repository navigation
Conversation
bIackr0se
marked this pull request as ready for review
September 23, 2026 10:03
Owner
|
Thanks for the contribution and the supporting detail. The project is focusing on maintaining a native MLX port aligned with upstream Laya. We are not merging this independent benchmark-documentation change in the current upstream-sync release. The distinction between historical and newer measurements remains acknowledged in #11. Closing this thread under that maintenance policy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11. The README latency figures came from an older run than the committed 22 September FP16 results in
BENCHMARKS.md. Both READMEs and the suggested launch copy now use the 22 September figures. The dated 19 September research notes keep their original figures, with links pinned to the benchmark commit that produced them.A regression test compares the published figures with the committed benchmark JSON and checks the historical links.
Tests
uv run --python 3.12 --frozen --extra dev --extra demo --extra reference pytest -q: 151 passeduv run --python 3.12 --frozen --extra dev --extra demo --extra reference ruff check .: passeduv run --python 3.12 --frozen --extra dev --extra demo --extra reference ruff format --check .: passeduv run --python 3.12 --frozen --extra dev --extra demo --extra reference python -m build: wheel and sdist built