Skip to content

[WIP] [Draft] Bump PHP to 8.1 & Symfony to 5.4 plus dependencies#90

Open
jefferya wants to merge 18 commits intomjordan:mainfrom
jefferya:jefferya/php_8.1_syfony_5.4
Open

[WIP] [Draft] Bump PHP to 8.1 & Symfony to 5.4 plus dependencies#90
jefferya wants to merge 18 commits intomjordan:mainfrom
jefferya:jefferya/php_8.1_syfony_5.4

Conversation

@jefferya
Copy link

@jefferya jefferya commented Jan 19, 2023

In-progress.

The problem: update to PHP 8 and Symfony 5.4 LTS versions (plus dependancies) and remove deprecation messages

  • Update to PHP 8.1, Symphony 5.4 (LTS version) and dependencies
  • Fixes:
    • Symfony v4 deprecation: "Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand
    • Command::execute() should always return int in Symfony 5+
    • Twig v2.7 deprecations

What has been tested

The testing infrastructure is defined: in https://github.com/cwrc/isle-bagger which builds upon an Isle Buildkit PHP 8.1 container (unreleased as of 2023-01-19) -- see the aforementioned link for details.

Todo:

@jefferya jefferya force-pushed the jefferya/php_8.1_syfony_5.4 branch from 39eae4f to 8cf4c59 Compare January 19, 2023 22:48
* Removing the security.yaml file as security is not enabled, at present, and I'm not sure how to do the equivalent in the new authenticator component
* Deprecate FirewallConfig::allowsAnonymous() and the allows_anonymous from the data collector data, there will be no anonymous concept as of version 6 - https://github.com/symfony/security-bundle/blob/5.4/CHANGELOG.md.
* Since symfony/security-core 5.4: The "Symfony\Component\Security\Core\Authentication\Token\AnonymousToken" class is deprecated.
* Since symfony/security-bundle 5.3: The "security.authentication.listener.anonymous.main" service is deprecated, use the new authenticator system instead
* "Since symfony/security-bundle 5.3: The \"security.authentication.manager\" service is deprecated, use the new authenticator system instead"
…ice" service is deprecated, use "session.storage.factory.native", "session.storage.factory.php_bridge" or "session.storage.factory.mock_file" instead.
* RouteCollectionBuilder deprecated
* Bump Symfony components
* Since symfony/framework-bundle 5.1: Using type \"Symfony\\Component\\Routing\\RouteCollectionBuilder\" for argument 1 of method \"App\\Kernel:configureRoutes()\" is deprecated, use \"Symfony\\Component\\Routing\\Loader\\Configurator\\RoutingConfigurator\" instead.
 * "Symfony\Component\HttpKernel\KernelInterface::registerBundles()" might add "iterable" as a native return type declaration in the future. Do the same in implementation "App\Kernel" now to avoid errors
@jefferya jefferya force-pushed the jefferya/php_8.1_syfony_5.4 branch from dcd307f to 788eebc Compare March 9, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants