Skip to content

Added ability to skip items with disabledClass. Useful when sorting over disabled or hidden items. #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 2.0alpha
Choose a base branch
from
Open

Added ability to skip items with disabledClass. Useful when sorting over disabled or hidden items. #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a56e305
Added ability to skip items with disabledClass. Useful when sorting …
poscar Jan 17, 2014
3b03132
Added disabledClass option to README.
poscar Jan 17, 2014
4fa262d
Fixed skipping over disabled elements when they are visible.
poscar Jan 17, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@ Also, the default list type is `<ol>`.
<dd>Given to collapsed branches when dragging an item over them. Default: <b>mjs-nestedSortable-hovering</b></dd>
<dt>leafClass (2.0)<dt>
<dd>Given to items that do not have children. Default: <b>mjs-nestedSortable-leaf</b></dd>
<dt>disabledClass (2.0)<dt>
<dd>Given to items that should be skipped when sorting over them. For example, non-visible items that are still part of the list. Default: <b>mjs-nestedSortable-disabled</b></dd>
</dl>

## Custom Methods
Expand Down
28 changes: 25 additions & 3 deletions jquery.mjs.nestedSortable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@
errorClass: 'mjs-nestedSortable-error',
expandedClass: 'mjs-nestedSortable-expanded',
hoveringClass: 'mjs-nestedSortable-hovering',
leafClass: 'mjs-nestedSortable-leaf'
leafClass: 'mjs-nestedSortable-leaf',
disabledClass: 'mjs-nestedSortable-disabled'
},

_create: function() {
Expand Down Expand Up @@ -178,6 +179,27 @@
continue;
}

// No action if intersected item is disabled
// and the element above or below in the direction we're going is also disabled
if (itemElement.className.indexOf(o.disabledClass) !== -1) {
// Note: intersection hardcoded direction values from jquery.ui.sortable.js:_intersectsWithPointer
if (intersection === 2) {
// Going down
var itemAfter = this.items[i + 1];
if (itemAfter && itemAfter.item[0].className.indexOf(o.disabledClass) !== -1){
continue;
}

}
else if (intersection === 1) {
// Going up
var itemBefore = this.items[i - 1];
if (itemBefore && itemBefore.item[0].className.indexOf(o.disabledClass) !== -1){
continue;
}
}
}

// cannot intersect with itself
// no useless actions that have been done before
// no action if the item moved is the parent of the item checked
Expand Down Expand Up @@ -257,7 +279,7 @@
// mjs - to find the previous sibling in the list, keep backtracking until we hit a valid list item.
var previousItem = this.placeholder[0].previousSibling ? $(this.placeholder[0].previousSibling) : null;
if (previousItem != null) {
while (previousItem[0].nodeName.toLowerCase() != 'li' || previousItem[0] == this.currentItem[0] || previousItem[0] == this.helper[0]) {
while (previousItem[0].nodeName.toLowerCase() != 'li' || previousItem[0].className.indexOf(o.disabledClass) !== -1 || previousItem[0] == this.currentItem[0] || previousItem[0] == this.helper[0]) {
if (previousItem[0].previousSibling) {
previousItem = $(previousItem[0].previousSibling);
} else {
Expand All @@ -270,7 +292,7 @@
// mjs - to find the next sibling in the list, keep stepping forward until we hit a valid list item.
var nextItem = this.placeholder[0].nextSibling ? $(this.placeholder[0].nextSibling) : null;
if (nextItem != null) {
while (nextItem[0].nodeName.toLowerCase() != 'li' || nextItem[0] == this.currentItem[0] || nextItem[0] == this.helper[0]) {
while (nextItem[0].nodeName.toLowerCase() != 'li' || nextItem[0].className.indexOf(o.disabledClass) !== -1 || nextItem[0] == this.currentItem[0] || nextItem[0] == this.helper[0]) {
if (nextItem[0].nextSibling) {
nextItem = $(nextItem[0].nextSibling);
} else {
Expand Down