Fix Claude plugin skills path and pack integrity guard#661
Merged
mksglu merged 5 commits intoMay 22, 2026
Conversation
f16bcd9 to
98254e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude-plugin/plugin.jsonat the shipped top-level./skills/directorystart.mjs,server.bundle.mjs, orcli.bundle.mjsis missing from the plugin rootnpm pack --dry-runinclude the Claude manifest,start.mjs, runtime bundles, and top-level skillsWhy
This closes the first failure mode in #658: the published package contains
skills/..., but the Claude plugin manifest pointed at./.claude/skills/, which is not shipped.It also covers the later install-corruption report where the manifest loads but
start.mjs/server.bundle.mjsare absent, leaving the host looking connected while exposing zero MCP tools. The build-chain asserter now catches that shape directly when run against a package or plugin-root checkout.Verification
node scripts/assert-asymmetric-drift.mjsnpm_config_cache=/tmp/npm-cache-context-mode npm pack --dry-run --json | node -e ...npm_config_cache=/tmp/npm-cache-context-mode npx vitest run tests/scripts/asymmetric-drift-assert.test.tsNote:
corepack pnpm exec vitest ...could not run before local dependency install because this checkout has nopnpm-lock.yamland no installedvitest; I used npm with an isolated cache for the targeted test.Closes #658