Skip to content

make default_optimizer thread safe #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

make default_optimizer thread safe #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Pathfinder.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@ export PathfinderResult, MultiPathfinderResult
export pathfinder, multipathfinder

const DEFAULT_HISTORY_LENGTH = 6
const DEFAULT_LINE_SEARCH = LineSearches.HagerZhang()
const DEFAULT_LINE_SEARCH_INIT = LineSearches.InitialHagerZhang()
const DEFAULT_LINE_SEARCH_CONSTRUCTOR = LineSearches.HagerZhang
const DEFAULT_LINE_SEARCH_INIT_CONSTRUCTOR = LineSearches.InitialHagerZhang
Comment on lines +27 to +28
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the constant name and just make it the constructor instead of the object.

Suggested change
const DEFAULT_LINE_SEARCH_CONSTRUCTOR = LineSearches.HagerZhang
const DEFAULT_LINE_SEARCH_INIT_CONSTRUCTOR = LineSearches.InitialHagerZhang
const DEFAULT_LINE_SEARCH = LineSearches.HagerZhang
const DEFAULT_LINE_SEARCH_INIT = LineSearches.InitialHagerZhang

const DEFAULT_NDRAWS_ELBO = 5

function default_optimizer(history_length)
return Optim.LBFGS(;
m=history_length,
linesearch=DEFAULT_LINE_SEARCH,
alphaguess=DEFAULT_LINE_SEARCH_INIT,
linesearch=DEFAULT_LINE_SEARCH_CONSTRUCTOR(),
alphaguess=DEFAULT_LINE_SEARCH_INIT_CONSTRUCTOR(),
Comment on lines +34 to +35
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
linesearch=DEFAULT_LINE_SEARCH_CONSTRUCTOR(),
alphaguess=DEFAULT_LINE_SEARCH_INIT_CONSTRUCTOR(),
linesearch=DEFAULT_LINE_SEARCH(),
alphaguess=DEFAULT_LINE_SEARCH_INIT(),

)
end

Expand Down
Loading