Skip to content

Fix off‑by‑one when using --max_examples in language/bert/evaluate_v1.1.py #2266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix off‑by‑one when using --max_examples in language/bert/evaluate_v1.1.py #2266

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6ce1c7
Fix counter increment position in BERT evaluation script
sbite0138 Jul 18, 2025
6f46fef
Merge branch 'master' into fix-bert-evaluation-counter
arjunsuresh Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions language/bert/evaluate_v1.1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,6 @@ def evaluate(dataset, predictions, max_examples=None):
if max_examples and max_examples == total:
break
for qa in paragraph["qas"]:
total += 1
if max_examples and max_examples == total:
break

if qa["id"] not in predictions:
message = (
"Unanswered question " +
Expand All @@ -94,6 +90,9 @@ def evaluate(dataset, predictions, max_examples=None):
)
f1 += metric_max_over_ground_truths(
f1_score, prediction, ground_truths)
total += 1
if max_examples and max_examples == total:
break

exact_match = 100.0 * exact_match / total
f1 = 100.0 * f1 / total
Expand Down