-
Notifications
You must be signed in to change notification settings - Fork 574
Remove rclone references and update download instructions for DeepSeek-R1, Llama 3.1 8b, and Whisper #2289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove rclone references and update download instructions for DeepSeek-R1, Llama 3.1 8b, and Whisper #2289
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Shall we keep both methods? |
We will hopefully be deprecating the Rclone method eventually, as it requires publicly sharing API keys and is a source of issues on account of people using different version of Rclone that behave differently, as well as folks incorrectly configuring Rclone remotes. The R2 downloader runs with a single command that handles everything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR @anivar. Looking over the download commands in the modified README.md files, the commands are incorrect, pointing to JSON files instead of the URI files in the commands on the download site: https://inference.mlcommons-storage.org
My concern is that users who prefer not to use the downloader should have an alternative — such as providing the Hugging Face URL — in case the downloader becomes inaccessible or stops working. |
be566a4
to
c1f697e
Compare
@nathanw-mlc Thank you for the review! I've updated the PR to address your feedback. The download commands have been corrected to use the proper URI files from the metadata directory instead of JSON files:
All URLs now correctly point to |
The MLC R2 Downloader is downloading from the same location as the Rclone commands; that location being R2 buckets maintained by MLCommons. If the models and datasets are taken from another public location, such as HuggingFace, we often do provide point out where that is so folks can download it there if need be. I see that that has not done for some of the README files modified by this PR. Folks in the Inference Working Group can make that addition in another PR. |
@nathanw-mlc Thanks for pointing that out! You're right - I focused on fixing the download URLs but didn't add the alternative sources like HuggingFace. Since the Inference Working Group can handle adding those alternative download locations in a follow-up PR, should this PR be good to merge as-is? |
…k-R1, Llama 3.1 8b, and Whisper - Replace rclone-based download instructions with new MLCommons downloader infrastructure - Update DeepSeek-R1, Llama 3.1 8b, and Whisper READMEs to use https://inference.mlcommons-storage.org - Maintain MLCFlow automation commands alongside native download methods - Add file size information for each download - Include -d flag documentation for custom download directories Fixes mlcommons#2265
…ect URIs - Remove rclone-based download instructions - Replace .json URLs with correct .uri files from metadata directory - Update download commands for DeepSeek-R1, Llama 3.1 8b, and Whisper - Use new MLCommons downloader infrastructure - Remove file size information from download instructions
be09d60
to
a001c35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few tweaks, but it LGTM.
Thanks @nathanw-mlc for the fixes and improvements - especially catching that MLCFlow typo! 🙏 |
Hi folks, I've updated the MLCFlow commands for all three benchmarks in this PR. Thanks for the PR, @anivar. |
Thanks @anandhu-eng! |
This Friday is the submission deadline :) |
Hi team, This has been approved for a while now. Any reason for the delay in merging? |
The delay was due to the inference submission where code freeze was in place. Even though the changes in in this PR are good there were some breaking changes and the WG did not want to disturb the submissions. Since it was already approved, I'm merging it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously approved by WG
Summary
Changes
https://inference.mlcommons-storage.org
-d
flag for custom download directoriesTest plan
Fixes #2265