Skip to content

Conversation

@anhappdev
Copy link

This PR introduces a new enforce_max_duration setting to the LoadGen test configuration. This allows users to control whether exceeding max_duration should terminate query issuance early and how minimum query count validation is applied.

Key Changes

•	Exposes enforce_max_duration in Python bindings and test settings (default: true).
•	IssueQueryController only stops early and logs when enforcement is enabled.
•	Results logic updates: min_query_count is skipped when enforcement is disabled.
•	Effective settings logging updated to include the new flag.
•	Submission checker ensures official submissions must enable enforcement.

The changes are taken from the branch https://github.com/mlcommons/inference/commits/mobile_update/, which is now outdated and therefore not possible to merge into master without resolving a conflict.

Motivation

We've maintained this change in a separate branch called mobile_update until now. This makes it difficult to update the loadgen version, so we want to merge this change into the master branch.

Related issues:

mlcommons/mobile_app_open#798
#1621

@anhappdev anhappdev requested a review from a team as a code owner November 21, 2025 03:42
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@anhappdev
Copy link
Author

anhappdev commented Nov 21, 2025

@pgmpablo157321 @freedomtan Please review this PR.

@anhappdev anhappdev force-pushed the enforce-max-duration branch from 849d1e2 to f3471ac Compare November 21, 2025 03:54
@arjunsuresh
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants