Skip to content

Update python requirement #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 23, 2025
Merged

Update python requirement #1359

merged 8 commits into from
Oct 23, 2025
+341 −441

Conversation

@superdosh
Copy link
Contributor

@superdosh superdosh commented Oct 20, 2025 •
edited
Loading

Also: fix bug where certain hugging face errors were silently ignored
Also: no longer require secrets file to exist
Also: allow EnsembleAnnotator to have secrets directly injected

https://github.com/mlcommons/sugar/issues/192

@superdosh superdosh temporarily deployed to Scheduled Testing October 20, 2025 20:45 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 20, 2025 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@superdosh superdosh marked this pull request as ready for review October 20, 2025 20:47
@superdosh superdosh requested a review from a team as a code owner October 20, 2025 20:47
@superdosh superdosh temporarily deployed to Scheduled Testing October 22, 2025 12:49 — with GitHub Actions Inactive
@superdosh superdosh temporarily deployed to Scheduled Testing October 22, 2025 13:30 — with GitHub Actions Inactive
@superdosh superdosh changed the title Update python requirement to >=3.12.6. Update python requirement Oct 22, 2025
@superdosh superdosh temporarily deployed to Scheduled Testing October 22, 2025 13:39 — with GitHub Actions Inactive
@superdosh superdosh temporarily deployed to Scheduled Testing October 22, 2025 17:26 — with GitHub Actions Inactive
@superdosh superdosh temporarily deployed to Scheduled Testing October 22, 2025 17:32 — with GitHub Actions Inactive
@superdosh superdosh temporarily deployed to Scheduled Testing October 22, 2025 17:34 — with GitHub Actions Inactive
@superdosh superdosh marked this pull request as draft October 22, 2025 17:52
@superdosh superdosh temporarily deployed to Scheduled Testing October 22, 2025 17:53 — with GitHub Actions Inactive
@superdosh superdosh marked this pull request as ready for review October 22, 2025 18:01
@superdosh
Copy link
Contributor Author

@bkorycki @rogthefrog sorry for the noise; this is now ready to review. And it works with the latest cheval updates here: https://github.com/mlcommons/sugar/pull/202

bkorycki
bkorycki approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@bkorycki bkorycki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I think moving the ensemble UIDs here will also allow us to greatly simplify the modelgauge safe and security test code. But we can do that when we get rid of modelbench-private.

@superdosh superdosh merged commit 7629145 into main Oct 23, 2025
2 checks passed
@superdosh superdosh deleted the update-python-dep branch October 23, 2025 12:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bkorycki bkorycki bkorycki approved these changes

@rogthefrog rogthefrog Awaiting requested review from rogthefrog

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@superdosh @bkorycki