Fix: truncate model identifier in case model name is too long#120
Open
younesbelkada wants to merge 1 commit intomlfoundations:mainfrom
Open
Fix: truncate model identifier in case model name is too long#120younesbelkada wants to merge 1 commit intomlfoundations:mainfrom
younesbelkada wants to merge 1 commit intomlfoundations:mainfrom
Conversation
Author
|
@RyanMarten @neginraoof let me know if this change looks good to you or if there is any better workaround for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per title, this PR fixes an issue where at the end of evaluation saving and loading model answer fails due to filename being too long (typically, when one passes many arguments for vLLM)
This PR fixes this by simply truncating the
model_identifierto something small in order to avoid this issueTested it on MTBench