Skip to content

Add normalizers when applied on a chain #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add normalizers when applied on a chain #1054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 42 additions & 1 deletion src/modules/kdenlive/filter_freeze.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,13 @@
#include <framework/mlt_producer.h>
#include <framework/mlt_property.h>
#include <framework/mlt_service.h>
#include <framework/mlt_tokeniser.h>

#include <stdio.h>
#include <string.h>

static mlt_properties normalizers = NULL;

static int filter_get_image(mlt_frame frame,
uint8_t **image,
mlt_image_format *format,
Expand Down Expand Up @@ -66,7 +69,8 @@ static int filter_get_image(mlt_frame frame,
mlt_producer_seek(producer, pos);

// Get the frame
mlt_service_get_frame(MLT_PRODUCER_SERVICE(producer), &freeze_frame, 0);
mlt_service service = MLT_PRODUCER_SERVICE(producer);
mlt_service_get_frame(service, &freeze_frame, 0);

mlt_properties freeze_properties = MLT_FRAME_PROPERTIES(freeze_frame);
mlt_properties frame_properties = MLT_FRAME_PROPERTIES(frame);
Expand All @@ -90,6 +94,43 @@ static int filter_get_image(mlt_frame frame,
(mlt_destructor) mlt_frame_close,
NULL);
mlt_properties_set_position(properties, "_frame", pos);
// Check if we have normalizers
int hasNormalizers = 0;
for (int i = 0; i < mlt_service_filter_count(service); i++) {
mlt_filter filter = mlt_service_filter(service, i);
if (filter && mlt_properties_get_int(MLT_FILTER_PROPERTIES(filter), "_loader") == 1) {
hasNormalizers = 1;
break;
}
}
if (hasNormalizers == 0) {
// Tokeniser
mlt_tokeniser tokeniser = mlt_tokeniser_init();

// We only need to load the normalizing properties once
if (normalizers == NULL) {
char temp[PATH_MAX];
snprintf(temp, sizeof(temp), "%s/core/loader.ini", mlt_environment("MLT_DATA"));
normalizers = mlt_properties_load(temp);
mlt_factory_register_for_clean_up(normalizers, (mlt_destructor) mlt_properties_close);
}

// Apply normalizers
for (int i = 0; i < mlt_properties_count(normalizers); i++) {
int j = 0;
int created = 0;
char *value = mlt_properties_get_value(normalizers, i);
mlt_tokeniser_parse_new(tokeniser, value, ",");
for (j = 0; !created && j < mlt_tokeniser_count(tokeniser); j++) {
const char *filter_name = mlt_tokeniser_get_string(tokeniser, j);
mlt_filter norm_filter = mlt_factory_filter(mlt_service_profile(MLT_FILTER_SERVICE(filter)), filter_name, NULL);
mlt_filter_process(norm_filter, freeze_frame);
}
}

// Close the tokeniser
mlt_tokeniser_close(tokeniser);
}
}
mlt_service_unlock(MLT_FILTER_SERVICE(filter));

Expand Down