Reduce range of gamma and gain in the color grading filter#1621
Merged
Reduce range of gamma and gain in the color grading filter#1621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested here:
https://forum.shotcut.org/t/color-grading-wheels-sensitivity-curve/36563
This is one proposal to improve the range.
In my assessment, the lift slider has a good amount of range.
The gamma slider had a range from 0.0-2.0. This proposal changes it to 0.5-2.0.
The gain slider had a range from 0.0-4.0. This proposal changes it to 0.5-2.0
I added a new "version" property to the filter. If a project is opened with a legacy filter, the range will use the old range (V0). If a new filter is added, it will use the new range (V1).
I think the proposed ranges still give enough dramatic effect at the extremes to meet most use cases. If users really want extreme color changes, they can stack multiple filters. But i think that is unlikely.