Skip to content

Conversation

@speaking-in-code
Copy link

This is the start of a fix for #1. I think the issues impact tool_mobile and screenshots as well.

I'm fairly new to the flutter package ecosystem. Feedback on better ways to do this would be great.

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #2 into master will increase coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   47.80%   48.15%   +0.34%     
==========================================
  Files          20       20              
  Lines        1550     1541       -9     
==========================================
+ Hits          741      742       +1     
+ Misses        809      799      -10     
Impacted Files Coverage Δ
lib/src/base/file_system.dart 44.68% <ø> (+6.49%) ⬆️
lib/src/base/process_manager.dart 100.00% <ø> (+90.90%) ⬆️
lib/src/cache.dart 37.56% <0.00%> (-0.50%) ⬇️
lib/src/base/utils.dart 40.79% <0.00%> (-0.21%) ⬇️
lib/src/base/context.dart 60.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5469bac...adf5b04. Read the comment docs.

@jonjon1123
Copy link

@mmcc007 Can we get this merged and a new package pushed up to work with Flutter 1.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants