Skip to content

fix: random black screen crashes with setShouldSetShouldHaltWhenReceivesControl#43

Merged
gmegidish merged 1 commit into
mainfrom
release/0.0.18
May 4, 2026
Merged

fix: random black screen crashes with setShouldSetShouldHaltWhenReceivesControl#43
gmegidish merged 1 commit into
mainfrom
release/0.0.18

Conversation

@gmegidish
Copy link
Copy Markdown
Member

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dbf5984f-42e7-49a3-997b-4eb5419c4b66

📥 Commits

Reviewing files that changed from the base of the PR and between 70c024d and 7a31e13.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • DeviceKitTests/devicekit_iosUITests.swift

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting


Walkthrough

This pull request includes two primary modifications. First, the CHANGELOG.md file was updated with new release entries for versions 0.0.18 (May 4, 2026) and 0.0.17 (May 3, 2026), documenting fixes and features related to XCTest behavior, placeholder formatting, test runner halting, and documentation updates. Second, the test setup method in DeviceKitTests/devicekit_iosUITests.swift was enhanced to include an additional runtime check that disables the private XCTest selector setShouldSetShouldHaltWhenReceivesControl: via KVC, preventing automatic re-enabling of the shouldHaltWhenReceivesControl property during test execution.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release/0.0.18

Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@gmegidish gmegidish merged commit 9562f3a into main May 4, 2026
2 of 3 checks passed
@gmegidish gmegidish deleted the release/0.0.18 branch May 4, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant