Skip to content

add the useDeepEquality and equals fields for code generation #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add the useDeepEquality and equals fields for code generation #1003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
204fbb6
add the useDeepEquality and equals fields for code generation
Neelansh-ns Jun 19, 2024
a2190d6
updated CHANGELOG.md and bump to 2.6.2
Neelansh-ns Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mobx_codegen/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.6.2

- Adds `useDeepEquality` and `equals` fields in code generation while creating observables by [@Neelansh](https://github.com/Neelansh-ns)

## 2.6.1

- Upgrading packages and sdk
Expand Down
8 changes: 8 additions & 0 deletions mobx_codegen/lib/src/store_class_visitor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ class StoreClassVisitor extends SimpleElementVisitor {
isReadOnly: _isObservableReadOnly(element),
isLate: element.isLate,
equals: _getEquals(element),
useDeepEquality: _doesObservableUseDeepEquality(element),
);

_storeTemplate.observables.add(template);
Expand All @@ -116,6 +117,13 @@ class StoreClassVisitor extends SimpleElementVisitor {
?.toBoolValue() ??
false;

bool _doesObservableUseDeepEquality(FieldElement element) =>
_observableChecker
.firstAnnotationOfExact(element)
?.getField('useDeepEquality')
?.toBoolValue() ??
false;

ExecutableElement? _getEquals(FieldElement element) => _observableChecker
.firstAnnotationOfExact(element)
?.getField('equals')
Expand Down
8 changes: 4 additions & 4 deletions mobx_codegen/lib/src/template/observable.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,10 @@ class ObservableTemplate {
return '''
@override
set $name($type value) {
$atomName.reportWrite(value, super.$name, () {
super.$name = value;
}${equals != null ? ', equals: ${equals!.name}' : ''}${useDeepEquality != null ? ', useDeepEquality: $useDeepEquality' : ''});
}''';
$atomName.reportWrite(value, super.$name, () {
super.$name = value;
}${equals != null ? ', equals: ${equals!.enclosingElement.name != null ? '${equals!.enclosingElement.name}.' : ''}${equals!.name}' : ''}${useDeepEquality != null ? ', useDeepEquality: $useDeepEquality' : ''});
}''';
}

@override
Expand Down
2 changes: 1 addition & 1 deletion mobx_codegen/lib/version.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Generated via set_version.dart. !!!DO NOT MODIFY BY HAND!!!

/// The current version as per `pubspec.yaml`.
const version = '2.6.1';
const version = '2.6.2';
2 changes: 1 addition & 1 deletion mobx_codegen/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: mobx_codegen
description: Code generator for MobX that adds support for annotating your code with @observable, @computed, @action and also creating Store classes.
version: 2.6.1
version: 2.6.2

repository: https://github.com/mobxjs/mobx.dart
issue_tracker: https://github.com/mobxjs/mobx.dart/issues
Expand Down