BUGFIX: Set up site in determined dimension and set up I18n service with the proper locale to also show translations from XLIFF files in correct language. #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith the proper locale to also show translations from XLIFF files in correct language.
Contributor
Author
|
I also have tighten the version constraints and would suggest a major release. The setting of the language dimension name might be breaking. |
…ith the proper locale to also show translations from XLIFF files in correct language.
…ith the proper locale to also show translations from XLIFF files in correct language.
Contributor
Author
|
@aertmann Would be great, if you can have a look into this. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixe ensures, that site node is set in correct dimensions. Also it sets the locale of the language dimension as locale for the I18n service.