feat: add typescript-async-loaders example#123
Conversation
Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>
|
Thanks @TG199 ! I reworked this example to simplify it and added a readme, please let me know if I accidentally removed anything critical :) |
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
LGTM, with the one note on the last bit of phrasing in the README.md. 🚀
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Oh, except for the failing test builds in CI.
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
|
Yeah lerna doesn't like NODE_OPTIONS, @TG199 if you could look into a fix for that we'd appreciate it, otherwise I'll come back to this one in a bit |
|
Alright, I'll look into it |
|
👋 @TG199 is this still on your radar? Are you waiting on us for anything? |
|
Oh I remember this one, not really waiting on anything. I'll get this done, thanks. |
|
Hi @mark-wiemer @JoshuaKGoldberg! The previous CI logs have expired, so I've pushed a commit to trigger fresh CI runs so we can see the NODE_OPTIONS error and fix it. Could you please approve the workflow run? Thanks! |
|
@TG199 can you review the failure details and see if you can clean things up? You should also be able to run CI on your fork if you add |
…tibility Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>
|
@TG199 tests still failing :( please run them locally with the exact same versions of Node as the workflow is set to use. Let me know if you have any questions :) |
Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>
|
Hi @mark-wiemer I made some diffs :) |
|
Yikes still failing, on it |
PR Checklist
status: accepting prsOverview