Skip to content

feat: add typescript-async-loaders example#123

Open
TG199 wants to merge 6 commits intomochajs:mainfrom
TG199:typescript-async-loaders
Open

feat: add typescript-async-loaders example#123
TG199 wants to merge 6 commits intomochajs:mainfrom
TG199:typescript-async-loaders

Conversation

@TG199
Copy link

@TG199 TG199 commented Sep 21, 2025

PR Checklist

Overview

Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>
@TG199 TG199 changed the title Repo: Add typescript-async-loaders example feat: Add typescript-async-loaders example Sep 22, 2025
@TG199 TG199 changed the title feat: Add typescript-async-loaders example Feat: Add typescript-async-loaders example Sep 22, 2025
@mark-wiemer
Copy link
Member

Thanks @TG199 ! I reworked this example to simplify it and added a readme, please let me know if I accidentally removed anything critical :)

@JoshuaKGoldberg JoshuaKGoldberg changed the title Feat: Add typescript-async-loaders example feat: Add typescript-async-loaders example Sep 30, 2025
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the one note on the last bit of phrasing in the README.md. 🚀

@JoshuaKGoldberg JoshuaKGoldberg changed the title feat: Add typescript-async-loaders example feat: add typescript-async-loaders example Sep 30, 2025
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, except for the failing test builds in CI.

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@mark-wiemer
Copy link
Member

Yeah lerna doesn't like NODE_OPTIONS, @TG199 if you could look into a fix for that we'd appreciate it, otherwise I'll come back to this one in a bit

@TG199
Copy link
Author

TG199 commented Oct 2, 2025

Alright, I'll look into it

@JoshuaKGoldberg
Copy link
Member

👋 @TG199 is this still on your radar? Are you waiting on us for anything?

@TG199
Copy link
Author

TG199 commented Feb 5, 2026

Oh I remember this one, not really waiting on anything. I'll get this done, thanks.

@TG199
Copy link
Author

TG199 commented Feb 11, 2026

Hi @mark-wiemer @JoshuaKGoldberg!

The previous CI logs have expired, so I've pushed a commit to trigger fresh CI runs so we can see the NODE_OPTIONS error and fix it. Could you please approve the workflow run?

Thanks!

@mark-wiemer
Copy link
Member

@TG199 can you review the failure details and see if you can clean things up? You should also be able to run CI on your fork if you add workflow_dispatch to the workflow file :)

@mark-wiemer mark-wiemer removed the stale label Feb 16, 2026
…tibility

Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>
@mark-wiemer
Copy link
Member

@TG199 tests still failing :( please run them locally with the exact same versions of Node as the workflow is set to use. Let me know if you have any questions :)

Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>
@TG199 TG199 requested a review from mark-wiemer March 1, 2026 09:30
@TG199
Copy link
Author

TG199 commented Mar 1, 2026

Hi @mark-wiemer I made some diffs :)

@TG199
Copy link
Author

TG199 commented Mar 2, 2026

Yikes still failing, on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants