fix(test): replace wmic usage with native Windows API in v11.x branch#5694
Open
hainenber wants to merge 3 commits intomochajs:v11.xfrom
Open
fix(test): replace wmic usage with native Windows API in v11.x branch#5694hainenber wants to merge 3 commits intomochajs:v11.xfrom
wmic usage with native Windows API in v11.x branch#5694hainenber wants to merge 3 commits intomochajs:v11.xfrom
Conversation
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
mark-wiemer
changed the title
wmic usage with native Windows API in v11.x branchwmic usage with native Windows API in v11.x branch
Member
|
Test failure in the most recent run on this PR is long-known issue, I'm happy to merge, will give a few days for @mochajs/maintenance-crew to review :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Fixes #5670
Replace
wmicusage in Mocha v11 branch with native Windows API call to get list of children PIDs. I've modified to ensure new library calls are compatible with existing usage.Acceptance of threshold should be green CI after all ;)